Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rp2040 IRAM issues #2640

Merged
merged 3 commits into from
May 17, 2023
Merged

Fix Rp2040 IRAM issues #2640

merged 3 commits into from
May 17, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented May 16, 2023

Tracked down a few more issues where flash code may be called from interrupt routines.

I found a way to check this is to inspect the RAM code (at address 0x20000000 onwards) in the dissassembly output (out/Rp2040/debug/build/apps.dis) looking for any 'veneer' routines which are typically required for calls to flash (starting at 0x10000000).

@what-the-diff
Copy link

what-the-diff bot commented May 16, 2023

PR Summary

  • Implemented force inline for CriticalLock
    Enhanced performance by adding __forceinline to CriticalLock constructor and destructor
  • Modified PICO_MEM_IN_RAM setting
    Improved memory usage by changing PICO_MEM_IN_RAM value from 0 to 1 for pico target
  • Updated HardwareSPI submodule
    Upgraded HardwareSPI submodule to a new commit for better compatibility and stability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants