-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support path or buffer inputs to the x509 verify method #44
Support path or buffer inputs to the x509 verify method #44
Conversation
@astitt-ripple As you said before, we should handle the buffer and path in JavaScript land, keep using memory at the C++ bridge code. |
Any idea why travis-ci fails? I cannot see the logs, and |
Travis tests are failing for 0.10 and 0.12:
|
Ah I see now, thank you @Southern! I was able to reproduce the error locally, and copied in the polyfill from the mozilla developer portal. @yorkie I've updated the code to read the certs and CABundle in JS instead, and removed the corresponding C++ code edit: identified a memory leak in the ca buffer code earlier today, will have a fix soon. i apologize if this has caused any inconvenience. |
@astitt-ripple were you able to get this working? Looks like the tests passed when they were ran last. |
@Southern I was able to get it working 👍 There were some memory leak issues I found/resolved during testing as well. I can re-open a PR if this is something you'd consider merging. |
For your consideration, allows for the use case where it is more convenient to use certs and/or CAs from memory than from files.