BED-5264: Defend against time-based enumeration #1167
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add arbitrary hash checking in failure cases prior to actually checking the hash to ensure time consistency.
Motivation and Context
This PR addresses: BED-5264
Why is this change required? What problem does it solve?
Resolves potential security concern.
How Has This Been Tested?
Tested locally showing that user not found errors and user found errors both take between 1.5 and 2 seconds to complete arbitrarily.
Screenshots (optional):
Types of changes
Checklist: