Abort program if either background task fails #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I had forgotten previously, this reformats the code with no other changes.
I didn't want to pull in a big parser, so we just use the commandline and parse like that, falling back to previous behavoiur.
This uses select! instead of a try-join that would let background threads fail and the program continue anyhow. This was easiest to notice if the socket was already bound, as the exporter would keep running even as it was unable to serve any data. Now instead it properly fails and terminates cleanly, although maybe not signalling failure exit code.
Spindel
force-pushed
the
fail-properly-on-errors
branch
from
034044d to
8819dad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses select! instead of a try-join that would let background
threads fail and the program continue anyhow.
This was easiest to notice if the socket was already bound, as the
exporter would keep running even as it was unable to serve any data.
Now instead it properly fails and terminates cleanly, although maybe not
signalling failure exit code.