@External annotation
#1269
Merged
@External annotation
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
============================================
+ Coverage 91.04% 91.08% +0.03%
- Complexity 4667 4672 +5
============================================
Files 597 597
Lines 14801 14810 +9
Branches 842 845 +3
============================================
+ Hits 13476 13490 +14
+ Misses 1063 1061 -2
+ Partials 262 259 -3 |
|
@armiol, PTAL. |
armiol
approved these changes
Apr 29, 2020
| import static com.google.common.base.Preconditions.checkNotNull; | ||
| import static com.google.common.truth.Truth.assertThat; | ||
|
|
||
| @DisplayName("`External` attribute can be declared") |
There was a problem hiding this comment.
Is this about the attribute or the annotation? Please make it more clear.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
@Externalannotation to replace the(external = true)attribute in@Subscribe,@React, and@Commandannotations.