Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes validation requirements for
StringChange
andBytesChange
types. Previously,new_value
fields were required. It was so to encourage introducing commands that would start fromClear
(e.g.ClearDescription
) instead of having a command that would just accept a blank new value.The intention was good, but it introduced the following problems:
new_value
for fields of simple types. Such inconsistency makes the problem no.1 is even bigger.