[1.x] Prohibit calling Aggregate's state() from @Apply-er methods
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armiol
changed the title
s state()` properly available when loading after snapshot was madestate() properly available when loading after snapshot was made
Improve logging for the Aggregate testing utility.
armiol
changed the title
state() properly available when loading after snapshot was madestate() from @Apply-er methods
This was referenced Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset addresses #1499 by disallowing to call
state()method from aggregate appliers.Previously, end-users could rely on
Aggregate.state()from@Apply-ers. However, in some cases (such as the one described in #1499)state()does not reflect the last state of an aggregate. This is so because appliers are invoked in scope of a single transaction — be it when loading an aggregate instance from storage, or when applying the just-emitted events during the command dispatching. Until such a transaction is completed,state()does not reflect the model updates corresponding to the respective domain events. Using the returned state value most likely leads to bugs.The designed way has always been to use
builder()instead ofstate(), because it is kept up-to-date throughout the active aggregate transaction.Therefore, once this PR is merged, any calls to
state()from@Apply-annotated method will lead to anIllegalStateException.