Simplify archived/deleted #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/main/java/org/spine3/server/aggregate/AggregateStorage.java # server/src/main/java/org/spine3/server/storage/memory/InMemoryAggregateStorage.java # server/src/main/java/org/spine3/server/storage/memory/TenantRecords.java # server/src/test/java/org/spine3/server/aggregate/AggregateStorageVisibilityHandlingShould.java # server/src/test/java/org/spine3/server/storage/RecordStorageShould.java
armiol
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
@dmdashenkov LGTM. Please consult with @alexander-yevsyukov as well.
|
@alexander-yevsyukov PTAL |
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 92.96% 92.99% +0.02%
+ Complexity 2287 2285 -2
============================================
Files 226 226
Lines 7496 7498 +2
Branches 574 570 -4
============================================
+ Hits 6969 6973 +4
Misses 395 395
+ Partials 132 130 -2Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made methods
markArchivedandmakeDeletedvoidinstead ofbooleanto make the operations more fast.