Validation of Stand input #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
April 13, 2017 16:08
…scription` requests: declare it in the model definition.
…xt` value against the expected one.
…lidation rules defined in their Protobuf definition.
…system; Update `Stand` external API to include `StreamObserver` as a parameter to allow async responses. Add some utilities to work with `StreamObserver`s.
… a bit to simplify documenting.
…e to reuse it for the `Query` and `Topic` validation.
…rvers.noopObserver()` utility method to suite the `StandShould` needs better.
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
===========================================
+ Coverage 91.56% 91.7% +0.14%
- Complexity 2784 2839 +55
===========================================
Files 295 305 +10
Lines 9057 9234 +177
Branches 639 647 +8
===========================================
+ Hits 8293 8468 +175
- Misses 580 583 +3
+ Partials 184 183 -1 |
added 13 commits
April 19, 2017 14:47
# Conflicts: # server/src/test/java/org/spine3/server/Given.java
|
@alexander-yevsyukov PTAL. |
alexander-yevsyukov
approved these changes
Apr 24, 2017
| * | ||
| * @return an instance of {@code StreamObserver} which does nothing | ||
| */ | ||
| public static <T> StreamObserver<T> noopObserver() { |
There was a problem hiding this comment.
Can we have it as noOpObserver()? It would be consistent with other noOp things around.
| return new StreamObserver<T>() { | ||
| @Override | ||
| public void onError(Throwable t) { | ||
| delegate.onError(t); |
There was a problem hiding this comment.
Please check that this is tested. The Codecov Chrome plug-in shows to me that these lines are not covered.
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| // Do nothing. | ||
| throwable = t; |
There was a problem hiding this comment.
Please check if this is tested.
| public T firstResponse() { | ||
| final boolean noResponses = responses.isEmpty(); | ||
| if (noResponses) { | ||
| throw new IllegalStateException("No responses have been received yet"); |
There was a problem hiding this comment.
Please test this branch.
| * @return all objects received by this {@code StreamObserver} | ||
| */ | ||
| public List<T> responses() { | ||
| return newArrayList(responses); |
| * @return {@code true} if the response has been completed, {@code false} otherwise | ||
| */ | ||
| public boolean isCompleted() { | ||
| return completed; |
| */ | ||
| @Nullable | ||
| public Throwable getError() { | ||
| return throwable; |
| * @param query a related query | ||
| * @param error an error occurred | ||
| */ | ||
| protected InvalidQueryException(String messageText, |
There was a problem hiding this comment.
It looks like we can fit the method signature into one line. Please try.
| * @param request a related actor request | ||
| * @param error an error occurred | ||
| */ | ||
| InvalidRequestException(String messageText, |
There was a problem hiding this comment.
Can we fit into one line?
| private static RequestNotSupported<Query> missingInRegistry(TypeUrl topicTargetType) { | ||
| final String errorMessage = format("The query target type is not supported: %s", | ||
| topicTargetType.getTypeName()); | ||
| return new RequestNotSupported<Query>( |
There was a problem hiding this comment.
Please see if we can fit into one line here and below.
added 11 commits
April 24, 2017 23:10
# Conflicts: # server/src/main/java/org/spine3/server/event/EventBus.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the automatic validation of actor requests sent to
Standinstances.Each request
Messageis validated in two steps.Messagedefinition.Standinstance. In particular:TypeUrlofQuery.getTarget()must be exposed for reading;TypeUrlofTopic.getTarget()must be exposed for reading;Subscriptionmust be present in the subscription registry for it to activate or cancel.In addition, the public API of
Standhas been modified to send responses viaStreamObservers passed as method arguments:Stand.subscribe(Topic, StreamObserver<Subscription>);Stand.activate(Subscription, EntityUpdateCallback, StreamObserver<Response>);Stand.cancel(Subscription, StreamObserver<Response>);The validation errors are passed to the
StreamObserver.onError()callback in a unified way.