Command attributes #448
Merged
Command attributes #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed `Values` to `Wrappers` to better reflect the nature.
Also: * Eliminated `Classes` utility class moving its method to where they were used.
Even though these methods are internal API, consistent naming is easier to understand and would not require renaming should be open some of these methods.
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
============================================
- Coverage 91.7% 91.66% -0.04%
- Complexity 2843 2870 +27
============================================
Files 306 310 +4
Lines 9247 9386 +139
Branches 647 651 +4
============================================
+ Hits 8480 8604 +124
- Misses 583 595 +12
- Partials 184 187 +3 |
armiol
approved these changes
Apr 27, 2017
There was a problem hiding this comment.
@alexander-yevsyukov LGTM except for low coverage. But I think the bot tells the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds key-value map for
CommandContextand provides utilities for working with such custom attributes.Other changes:
instance()methods were renamed togetInstance()for consistency.Valuesutility class renamed toWrappers.Wrapperclass which is a converter and packer/unpacker.