Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 11 #211

Closed
andre15silva opened this issue Mar 1, 2021 · 13 comments · Fixed by #214
Closed

Support Java 11 #211

andre15silva opened this issue Mar 1, 2021 · 13 comments · Fixed by #214

Comments

@andre15silva
Copy link
Contributor

Currently Java >8 support is limited due to the tools.jar dependency.

It would be important to fix these compatibility issues as Nopol's usage in https://github.com/eclipse/repairnator will be limited when it moves to Java 11.

@monperrus monperrus changed the title Support Java >8 Support Java 11 Mar 16, 2021
@monperrus
Copy link
Contributor

Per the discussion in Repairnator, the blocking factor is the need of JDI for Dynamoth.

As solution, we will likely move on to Java 11 by only keeping the SMT-based synthesis (the one described in the TSE paper). The users of Dynamoth would then use a past commit.

@monperrus
Copy link
Contributor

The question is: where is com.sun.jdi in Java 11? by default in the JVM? Somewhere else?

@andre15silva
Copy link
Contributor Author

andre15silva commented Mar 18, 2021

The change was made in https://openjdk.java.net/jeps/220

Removed: rt.jar and tools.jar

The class and resource files previously stored in lib/rt.jar, lib/tools.jar, lib/dt.jar, and various other internal JAR files are now stored in a more efficient format in implementation-specific files in the lib directory. The format of these files is not specified and is subject to change without notice.

I have to dig more into it, but it's still in jdk11 https://docs.oracle.com/en/java/javase/11/docs/api/jdk.jdi/com/sun/jdi/package-summary.html

@monperrus
Copy link
Contributor

monperrus commented Mar 19, 2021 via email

@andre15silva
Copy link
Contributor Author

Does it mean that it is available by default (no need to add another jar as before)?

I think so. There are probably changes in the behaviour/API that impact Nopol, so I have to experiment to be sure it's that straightforward.

@monperrus
Copy link
Contributor

have to experiment to be sure it's that straightforward.

great, looking forward to the results

@monperrus
Copy link
Contributor

FTR, @Twonki @martinezmatias the tools.jar problem is fixed, see #214 (comment) thanks @andre15silva

GZoltar is the remaining problem. André, we have an ongoing effort to replace Gzoltar, by a new project called flacoco, see eclipse-repairnator/repairnator#1029 We may soon give Flacoco a high priority.

@monperrus
Copy link
Contributor

FYI @gynther-k is able to use GZoltar with Java 11, with the latest version as of commit gynther-k/TBar@d1b1555

@andre15silva
Copy link
Contributor Author

FYI @gynther-k is able to use GZoltar with Java 11, with the latest version as of commit gynther-k/TBar@d1b1555

I will take a look and update the PR

@gynther-k
Copy link

@monperrus @andre15silva
The modified Java11 .jar files is not used by default in my project but are located here: https://github.com/gynther-k/TBar/tree/test-1/lib/java11modified

I have made a PR to gzoltar with a more detailed description GZoltar/gzoltar#41 . I have no previous experience of gzoltar so please come with suggestions .

@monperrus
Copy link
Contributor

monperrus commented Apr 14, 2021 via email

@monperrus
Copy link
Contributor

@martinezmatias @andre15silva FYI PR merged in GZoltar GZoltar/gzoltar#41

@andre15silva
Copy link
Contributor Author

Nice. Thanks @gynther-k !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants