Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Removed com.sun.tools from System Scope #212

Closed
wants to merge 1 commit into from
Closed

WIP: Removed com.sun.tools from System Scope #212

wants to merge 1 commit into from

Conversation

lapplislazuli
Copy link

Hi,

this is an issue originating from SpoonLabs/astor#243 and similar to #211 .

The build proceeds fine, and when I use the 0.3-Snapshot Astor also builds without issues.
Astors tests run too, but some of them are failing.

However I must admit that the tests are failing, but I have no clue which ones are the serious ones.
Second look would be great @martinezmatias .

@martinezmatias
Copy link
Contributor

martinezmatias commented Mar 16, 2021

Hi @Twonki
Thanks for the PR.

However I must admit that the tests are failing, but I have no clue which ones are the serious ones.

I would say that some may fail due to the lack of the dependency on runtime.

@lapplislazuli lapplislazuli changed the title Removed com.sun.tools from System Scope WIP: Removed com.sun.tools from System Scope Mar 16, 2021
@lapplislazuli
Copy link
Author

Hmm, yes indeed, many classes actually need the JDI.

Some of these can be migrated using com.java.reflect, but others can't like com.sun.jdi.Value.
It would definetly need a bigger migration.

In terms of Astor, how important is Nopol for it? Is it just a plugin, or is it required for logic? @martinezmatias

@martinezmatias
Copy link
Contributor

Hi @Twonki

In terms of Astor, how important is Nopol for it? Is it just a plugin, or is it required for logic? @martinezmatias

It was used by some repair prototipes included in the framework (which have been under working), but not used by any of the main repair approaches we used in the experiments (Cardumen, jGenprog, jKali, etc). You can open an issue on Astor to discuss about that

@lapplislazuli
Copy link
Author

Will do!

@monperrus
Copy link
Contributor

Thanks for the update.

FTR, see #211 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants