Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized HashFieldExpireExecute #2851

Closed
wants to merge 1 commit into from
Closed

Optimized HashFieldExpireExecute #2851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions src/StackExchange.Redis/RedisDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,18 +414,47 @@ public Task<ExpireResult[]> HashFieldExpireAsync(RedisKey key, RedisValue[] hash
private T HashFieldExpireExecute<T, TProcessor>(RedisKey key, long milliseconds, ExpireWhen when, Func<bool, RedisCommand> getCmd, CustomExecutor<T, TProcessor> executor, TProcessor processor, CommandFlags flags, params RedisValue[] hashFields)
{
if (hashFields == null) throw new ArgumentNullException(nameof(hashFields));
var useSeconds = milliseconds % 1000 == 0;

bool useSeconds = (milliseconds % 1000) == 0;
var cmd = getCmd(useSeconds);
long expiry = useSeconds ? (milliseconds / 1000) : milliseconds;
long expiry = useSeconds ? milliseconds / 1000 : milliseconds;

int baseLength = (when == ExpireWhen.Always) ? 3 : 4;
int totalLength = baseLength + hashFields.Length;

bool usePool = totalLength > 16;
RedisValue[] values = usePool
? ArrayPool<RedisValue>.Shared.Rent(totalLength)
: new RedisValue[totalLength];

var values = when switch
try
{
ExpireWhen.Always => new List<RedisValue> { expiry, RedisLiterals.FIELDS, hashFields.Length },
_ => new List<RedisValue> { expiry, when.ToLiteral(), RedisLiterals.FIELDS, hashFields.Length },
};
values.AddRange(hashFields);
var msg = Message.Create(Database, flags, cmd, key, values.ToArray());
return executor(msg, processor);
values[0] = expiry;
if (when == ExpireWhen.Always)
{
values[1] = RedisLiterals.FIELDS;
values[2] = hashFields.Length;
}
else
{
values[1] = when.ToLiteral();
values[2] = RedisLiterals.FIELDS;
values[3] = hashFields.Length;
}
Array.Copy(hashFields, 0, values, baseLength, hashFields.Length);

RedisValue[] finalValues = usePool ? new RedisValue[totalLength] : values;
if (usePool)
Array.Copy(values, finalValues, totalLength);

var msg = Message.Create(Database, flags, cmd, key, finalValues);
return executor(msg, processor);
}
finally
{
if (usePool)
ArrayPool<RedisValue>.Shared.Return(values);
}
}

private static RedisCommand PickExpireCommandByPrecision(bool useSeconds) => useSeconds ? RedisCommand.HEXPIRE : RedisCommand.HPEXPIRE;
Expand Down
Loading