Remove dependency on mock

[suriya]

Postmarker has a dependency on mock, used here:

postmarker/postmarker/_compat.py

Line 13 in c0c0f7a

from mock import patch # noqa

I notice that mock.patch is used only in tests. Does this make sense to move the line to a separate file _compat_tests.py so that normal usage of postmarker does not need the mock package?

[Stranger6667]

Hi @suriya!
Sorry for not getting back to you.
This code is used in pytest integration, which is a part of the distribution. Thus it can't be moved to another place.

[suriya]

Of course it can be moved. You need two files, one that is imported and used in production and one that is imported and used only during testing. The mock mock dependency need not be in the production file.

[Stranger6667]

I completely agree with your motivation. The possible solution is to move mock to extras. For production, you could install postmarker and for your tests, you could install postmarker[testing] instead. What do you think?

[suriya]

My suggestion is simpler. Create a file called _compat_tests.py and import mock in that file. In production, that file will not be used.

[suriya]

@Stranger6667 Could you help with this issue?

[Stranger6667]

Should be fixed now. In a case of any issues, feel free to reopen it

[suriya]

Thank you so much!