Feat: Add Identity service #218

techsavvyash · 2023-04-18T12:30:44Z

Description

This PR contains the code for the identity service.

…magra as Git submodules Signed-off-by: Yash Mittal <[email protected]>

Signed-off-by: Yash Mittal <[email protected]>

.gitmodules

tejash-jl · 2023-06-21T07:49:50Z

services/identity-service/src/did/auth-jwt.strategy.ts

+        jwksRequestsPerMinute: 5,
+        jwksUri: process.env.JWKS_URI,
+      }),
+      algorithms: ['RS256'],


let this be configurable

added as an env var

tejash-jl · 2023-06-21T07:52:48Z

services/identity-service/src/did/did.service.ts

+
+  async generateDID(doc: GenerateDidDTO): Promise<DIDDocument> {
+    // Create private/public key pair
+    const authnKeys = await ION.generateKeyPair('Ed25519');


make it configurable.
RSA or ED

added as a env var

tejash-jl · 2023-06-21T07:53:29Z

services/identity-service/src/did/did.service.ts

+    console.log(authnKeys);
+
+    // Create a UUID for the DID using uuidv4
+    const didUri = 'did:ulp:' + uuid();


remove ULP keyword and make it configurable

done refer: 6af1cd1

tejash-jl · 2023-06-21T07:57:49Z

services/identity-service/src/did/did.service.ts

+        didDoc: JSON.stringify(document),
+      },
+    });
+    this.vault.writePvtKey(authnKeys.privateJwk, didUri)


await is missing?

also error handlings are missing,

tejash-jl · 2023-06-21T07:58:27Z

services/identity-service/src/did/did.service.ts

+    // const did = new ION.DID({
+    //   content: content,
+    // });
+
+    // const anchorRequestBody = await did.generateRequest();
+    // const didUri: string = await did.getURI('short');
+    // const anchorRequest = new ION.AnchorRequest(anchorRequestBody);
+    // const anchorResponse = await anchorRequest.submit();
+    // if (anchorResponse) {
+    //   await this.prisma.identity.create({
+    //     data: {
+    //       id: didUri,
+    //       didDoc: anchorResponse as DIDDocument,
+    //       privateKey: authnKeys.privateJwk,
+    //     },
+    //   });
+
+    //   return anchorResponse;
+    // } else {
+    //   throw new Error('err');
+    // }


remove commented codes

srprasanna · 2023-06-21T08:06:10Z

services/identity-service/build/Jenkinsfile

@@ -0,0 +1,45 @@
+node() {


Should this be present within the repo. I think this can be removed.

This is the jenkins file we created to deploy the service to the internal samagra devops pipelines. Do we need to remove this entirely so can we keep this as alternate deployment strategy ?

the file has been resolved as per discussion during the standup

srprasanna · 2023-06-21T08:06:37Z

services/identity-service/package.json

+  "description": "",
+  "author": "",
+  "private": true,
+  "license": "UNLICENSED",


Please add appropriate license.

Added MIT License

srprasanna · 2023-06-21T08:08:45Z

services/identity-service/src/did/did.controller.ts

+    }
+  }
+
+  // @Patch('/update/:id')


Delete if not required.

services/identity-service/src/did/did.controller.ts

srprasanna · 2023-06-21T08:10:56Z

services/identity-service/src/did/did.service.ts

+      authentication: ['auth-key'],
+    };
+    // print the document using pretty json
+    console.log(JSON.stringify(document, null, 2));


can be removed.

srprasanna · 2023-06-21T08:11:28Z

services/identity-service/src/did/did.service.ts

+    }
+  }
+
+  // async resolveDID(id: string): Promise<DIDDocument> {


comments should be removed everywhere.

srprasanna · 2023-06-21T08:12:48Z

services/identity-service/src/did/vault.service.ts

+    private vault = new Vault( {
+            https: false,
+            baseUrl: `${process.env.VAULT_ADDR}/v1`,
+            rootPath: `${process.env.VAULT_ADDR}/v1/kv`,


can be made configurable throughout. We can have vault address and root path as two env variables.

added as env vars

srprasanna · 2023-06-21T08:16:14Z

services/identity-service/src/kyc/dtos/RegisterUserDTO.dto.ts

@@ -0,0 +1,15 @@
+import { ApiProperty } from "@nestjs/swagger";
+
+export class RegisterUserDTO {


Why do we have OTP and password within a DTO. These should be handled by the authentication provider. Only consent should be transmitted.

this was a mock aadhar service, this code has been removed from the service

feat: Add targets for identity-service

tejash-jl · 2023-06-21T08:54:10Z

services/identity-service/src/did/did.service.ts

+  }
+
+  async resolveDID(id: string): Promise<any> {
+    console.log('did in resolveDID: ', id);


use nest js logger, and leverage different log levels

tejash-jl · 2023-06-21T10:53:29Z

docker-compose file is missing with vault & db service

tejash-jl · 2023-06-21T11:01:28Z

Enable JWT auth for APIs,

tejash-jl · 2023-06-21T11:03:17Z

@techsavvyash can you share the API spec for this service?

tejash-jl · 2023-06-21T11:04:55Z

services/identity-service/src/kyc/kyc.controller.ts

@@ -0,0 +1,36 @@
+import { BadRequestException, Body, Controller, Get, Param, Post } from '@nestjs/common';


Do we need these APIS?

no, these were written to enable a mock aadhar based login flow to create DIDs, and have been removed

tejash-jl · 2023-06-21T11:06:39Z

services/identity-service/src/vc/vc.controller.ts

+  @ApiInternalServerErrorResponse({ description: 'Internal Server Error' })
+  @Post('/sign')
+  sign(@Body() body: SignJsonDTO) {
+    console.log('tjis')


remove unwanted logs

tejash-jl · 2023-06-21T11:12:04Z

services/identity-service/src/vc/vc.controller.ts

+  @ApiOperation({ summary: 'Verify a signed VC' })
+  @Post('/verify')
+  verify(@Body() body: VerifyJsonDTO) {
+    return this.VcService.sign(body.DID, body.payload);


why does it call sign function for verify?

this has been resolved

Update setup_vault.sh

…to identity

Update setup_vault.sh

fix: Fix tests, docker-compose-test, and setup_vault.sh

feat: add health checks for DB container

#10) * feat: add health checks to vault and use test network for test containers * feat: health checks for identity service

services/identity-service/src/did/did.controller.ts

services/identity-service/src/did/did.service.ts

services/identity-service/src/main.ts

services/identity-service/src/vc/vc.service.ts

srprasanna · 2023-07-04T07:08:50Z

@techsavvyash Please add a readme with the list of supported environment variables as well. This way it will be easy to document at a later point.

srprasanna · 2023-07-04T07:20:31Z

@techsavvyash can you also share the coverage metrics?

…-core into identity

techsavvyash · 2023-07-04T09:57:39Z

@techsavvyash Please add a readme with the list of supported environment variables as well. This way it will be easy to document at a later point.

have added a .env.sample

techsavvyash · 2023-07-04T09:58:13Z

@techsavvyash can you also share the coverage metrics?

techsavvyash added 3 commits April 17, 2023 13:37

Feat: Add Credential, Credential Schema and Identity services from Sa…

cad6210

…magra as Git submodules Signed-off-by: Yash Mittal <[email protected]>

Feat: Add identity service

6265de0

Signed-off-by: Yash Mittal <[email protected]>

Feat: add sample env

d5a8b69

Signed-off-by: Yash Mittal <[email protected]>

techsavvyash marked this pull request as draft April 18, 2023 12:42

techsavvyash marked this pull request as ready for review June 15, 2023 08:57

This was referenced Jun 15, 2023

Feat: Credential Service #217

Merged

Master Ticket - Contribution to RC Unified-Learner-Passbook/Credential-MS#54

Open

tushar5526 added 3 commits June 20, 2023 11:44

feat: Add targets for identity-service

af2000b

feat: Add containerized tests

6ae6a53

feat: Update makefile

de7798b

tejash-jl reviewed Jun 20, 2023

View reviewed changes

.gitmodules Outdated Show resolved Hide resolved

tejash-jl reviewed Jun 21, 2023

View reviewed changes

srprasanna reviewed Jun 21, 2023

View reviewed changes

Merge pull request #1 from tushar5526/identity

7cd8731

feat: Add targets for identity-service

tejash-jl reviewed Jun 21, 2023

View reviewed changes

fix: remove .gitmodules, make did method dynamic

6af1cd1

tejash-jl assigned tejash-jl and srprasanna Jun 22, 2023

tushar5526 mentioned this pull request Jun 22, 2023

feat: Add 2.0 services in docker compose #231

Closed

feat: Fix dockerfile and add vault config

4b1abd7

techsavvyash and others added 20 commits June 27, 2023 21:23

Merge pull request #5 from tushar5526/patch-1

97a2eee

Update setup_vault.sh

feat: add verify endpoint

428123c

Merge branch 'identity' of github.com:techsavvyash/sunbird-rc-core in…

193bf06

…to identity

fix and enable auth guard

2de0ddf

fix: error handling logging and touchups

a6e2e4e

feat: tests

b399774

Update setup_vault.sh

f1bcc31

Merge pull request #7 from tushar5526/patch-2

9a366f7

Update setup_vault.sh

fix: Fix tests, docker-compose-test, and setup_vault.sh

b994fde

Merge pull request #8 from tushar5526/test-fix

3421b72

fix: Fix tests, docker-compose-test, and setup_vault.sh

feat: add health checks for DB container

7dd2719

fix: make tests working

b99a439

Merge pull request #9 from tushar5526/compose-fix

580a640

feat: add health checks for DB container

update tests

8e5a1b3

Update .env

8811c86

feat: add health check

c9ead04

fix: vault health check

31bd2fa

fix

6195bcd

feat: add health checks to vault and use test network for test contai… (

884f9d1

#10) * feat: add health checks to vault and use test network for test containers * feat: health checks for identity service

Merge branch 'main' into identity

97da68c

srprasanna changed the base branch from main to release-2.0.0 July 4, 2023 04:09

srprasanna reviewed Jul 4, 2023

View reviewed changes

techsavvyash added 2 commits July 4, 2023 15:13

fix: improvements

ce6ac5e

Merge branch 'identity' of https://github.com/techsavvyash/sunbird-rc…

f2d1bfd

…-core into identity

srprasanna approved these changes Jul 4, 2023

View reviewed changes

srprasanna merged commit ed43c7d into Sunbird-RC:release-2.0.0 Jul 5, 2023

		@@ -0,0 +1,15 @@
		import { ApiProperty } from "@nestjs/swagger";

		export class RegisterUserDTO {

		@@ -0,0 +1,36 @@
		import { BadRequestException, Body, Controller, Get, Param, Post } from '@nestjs/common';

Feat: Add Identity service #218

Feat: Add Identity service #218

Conversation

techsavvyash commented Apr 18, 2023 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tejash-jl commented Jun 21, 2023

tejash-jl commented Jun 21, 2023

tejash-jl commented Jun 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srprasanna commented Jul 4, 2023

srprasanna commented Jul 4, 2023

techsavvyash commented Jul 4, 2023

techsavvyash commented Jul 4, 2023

techsavvyash commented Apr 18, 2023 •

edited

Loading

tejash-jl commented Jun 21, 2023 •

edited

Loading