feat: add revocation functions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprasanna
reviewed
Sep 15, 2023
| credDID = await this.identityService.generateDID(['verifiable credential']); | ||
| } catch (err) { | ||
| Logger.error('Error generating DID for revocation list', err); | ||
| throw new InternalServerErrorException( |
There was a problem hiding this comment.
Instead of InternalServerErrorException, can we create an application specific exception.
srprasanna
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
@techsavvyash please use the digitalbazaar bitstring library, you can override existing functions within your credentials-service itself.
Also please replace InternalServerExceptions with Application specific exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds relevant functions implementing the vc revocation list. W3C discussion doc on revocation lists can be found here