add traffic class setting/option #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the smokeping prober to also run with configured ToS fields. This makes it a good replacement for https://github.com/fbegyn/joki with more upstream support and better implementation of histograms. Signed-off-by: Francis Begyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, the ToS/Traffic class field of packets is ignored by a lot of upstream devices. However, I have some use case where having the option to control the ToS field actually delivers some useful data (the routing directs packets to different QoS and uplinks based on the DSCP/ToS field).
I'd love to see this feature get accepted upstream, however I understand that adding another label field and some additional logic for these labels will bring additional maintenance and I'd be happy to keep it in a fork.
The additional label is needed since it is now possible to have multiple target groups with the same hosts, but different ToS values. I solved this with the
toslabel. I'll be running this at home and at a production event later this month to validate the stability.