Skip to content
This repository has been archived by the owner on Dec 25, 2024. It is now read-only.

Commit

Permalink
fix package names in log folder (#66)
Browse files Browse the repository at this point in the history
* fix package names in log folder

in the newer nixpkgs-review version the log now names
the package like PACKAGE-SYSTEM.log which will cause errors
like

```
Package is missing a meta section. If the package is using runCommand
please make sure to inherit or create a
meta section.

error: AttrPathNotFound Packages in
‘/nix/store/vx1psq29l9rhlvq01rf67wnx2avk0z6d-nixpkgs’ do not contain
‘k9s-x86_64’ attribute.
```

this commit now uses regex to filter the most common system names
(as defined by nixpkgs-review upstream[1])

[1]: https://github.com/Mic92/nixpkgs-review?tab=readme-ov-file#review-changes-for-other-operating-systemsarchitectures

Signed-off-by: Florian Brandes <[email protected]>

* Update nixpkgs-review-checks-hook

---------

Signed-off-by: Florian Brandes <[email protected]>
Co-authored-by: Sandro <[email protected]>
  • Loading branch information
gador and SuperSandro2000 authored Dec 25, 2024
1 parent e163c84 commit 752c7c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nixpkgs-review-checks-hook
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ _nixpkgs-review-checks-hook() {
# run commands for each package build
cd logs/ 2>/dev/null || exit
for package_log_file in *.log; do
package="${package_log_file%.*}"
package=$(echo $package_log_file | sed -nE "s/(.*?)-(x86_64-linux|aarch64-linux|x86_64-darwin|aarch64-darwin).log/\1/p")
lint_check_package=../lint_checks.$package.tmp

missingMeta="$(nix-instantiate --eval -E "(import ../nixpkgs { }).pkgs.$package.meta" || true)"
Expand Down

0 comments on commit 752c7c5

Please sign in to comment.