Let squished enemies fade out instead of vanishing instantly #3198
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squished enemies will now fadeout instead of vanishing instantly. This looks a bit smoother and is more aligned with the melting or burning animation.
|
Just an idea. Looks better to me when squished Badguys do not vanish instantly. If you do not like it, I can delete this PR. |
|
Could you please provide video footage? |
|
Looking good to me. |
MatusGuy
reviewed
Feb 24, 2025
| @@ -315,12 +317,18 @@ BadGuy::update(float dt_sec) | |||
| case STATE_SQUISHED: | |||
| m_is_active_flag = false; | |||
| if (m_state_timer.check()) { | |||
| remove_me(); | |||
| m_alpha_before_fadeout = m_sprite->get_alpha(); | |||
There was a problem hiding this comment.
An enemy at 0.5 alpha should fade out faster. In that case, you don't need this variable. You can multiply the fadeout time by the alpha in the set_state function.
| if (m_state_timer.check()) | ||
| remove_me(); | ||
| else | ||
| m_sprite->set_alpha(m_alpha_before_fadeout - (m_alpha_before_fadeout * m_state_timer.get_progress())); |
There was a problem hiding this comment.
And here you'd only need to put m_state_timer.get_progress()
Suggested change
| m_sprite->set_alpha(m_alpha_before_fadeout - (m_alpha_before_fadeout * m_state_timer.get_progress())); | |
| m_sprite->set_alpha(1.f - m_state_timer.get_progress())); |
| @@ -760,6 +768,9 @@ BadGuy::set_state(State state_) | |||
| case STATE_SQUISHED: | |||
| m_state_timer.start(SQUISH_TIME); | |||
| break; | |||
| case STATE_SQUISHED_FADING_OUT: | |||
| m_state_timer.start(FADEOUT_TIME); | |||
There was a problem hiding this comment.
Suggested change
| m_state_timer.start(FADEOUT_TIME); | |
| m_state_timer.start(FADEOUT_TIME * m_sprite.get_alpha()); |
| @@ -42,6 +42,7 @@ | |||
| static const float SQUISH_TIME = 2; | |||
| static const float GEAR_TIME = 2; | |||
| static const float BURN_TIME = 1; | |||
| static const float FADEOUT_TIME = 0.2f; | |||
There was a problem hiding this comment.
I'm not sure because I havent tested this in game but this might be too fast?? Someone else needs to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squished enemies will now fadeout instead of vanishing instantly. This looks a bit smoother and is more aligned with the melting or burning animation.