Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add custom CA certificate injection #171

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Jun 16, 2022

To properly do idle session culling amalthea needs to send a get request to https://<ful_session_path>/api/status.

In cases where self signed certificates are used this would fail without injecting these in amalthea.

@olevski olevski requested review from ableuler and a team as code owners June 16, 2022 13:31
@olevski olevski force-pushed the add-custom-certificates-injection branch from aa823c8 to 2102731 Compare June 16, 2022 13:32
@olevski
Copy link
Member Author

olevski commented Jun 17, 2022

<full_session_path> refers to what is usually the combination of <hostname>/sessions/<sesion_id> where the session can be accessed. I.e. it is the combination of the hostname and path in the ingress object created by amalthea.

Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@olevski olevski merged commit 5024dc3 into main Jun 22, 2022
@olevski olevski deleted the add-custom-certificates-injection branch June 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants