fix: return 409 error when creating a project with a conflicting slug #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
commented
Oct 18, 2024
| } | ||
| _, response = await sanic_client.post("/api/data/projects", headers=user_headers, json=payload) | ||
|
|
||
| assert response.status_code == 409, response.text |
There was a problem hiding this comment.
Note: prior to the fix, a HTTP 500 error would be returned, with leakage from postgres, see #308.
Pull Request Test Coverage Report for Build 11462035394Details
💛 - Coveralls |
olevski
previously approved these changes
Oct 21, 2024
Panaetius
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308.