-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix rclone schema and add support for validating storage connections #92
Conversation
Pull Request Test Coverage Report for Build 6972056243
💛 - Coveralls |
b72bdcc
to
79a39d8
Compare
12edfb0
to
af123ac
Compare
af123ac
to
d0cb4cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Panaetius I am not sure if this changed in this PR or not. But the generated code for the storage apispec does not match the current apispec yaml file. I.e. if I run make schemas
then I get changes in the generated python code for the storage apispec.
for some reason I thought that CI creates those. I've updated them now |
@Panaetius thanks for making the update. But the tests are failing now. Some endpoint is responding with a 422 whereas a 200 is expected. I think this is because of the apispec.py update. And yeah we dont have a CI action that updates the code generated from the apispec.yaml file. We can add one that generates the code or one that simply checks that the generated code and the stuff in the yaml file match. |
it was due to a change rok made a while ago that broke things, but we never updater the apispec.py file so it didn't have any effect. Would be nice to have a test that that is up to date in CI. bit annoying since it also updates the date line so needs more than a simple diff |
71905ed
to
12891d0
Compare
12891d0
to
4cf4cd1
Compare
@olevski I've added a test to ensure the schema is updated |
examples wasn't returned.
updates apispec
adds check to ensure apispec is up to date
adds testing of connections using rclone
fixes bug in apispec with nullable values for patch endpoint