Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cookie signing #734

Merged
merged 13 commits into from
Oct 15, 2024
Merged

feat: support cookie signing #734

merged 13 commits into from
Oct 15, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Oct 9, 2024

Adds support for cookie signing and encryption to the gateway.

Note: needs updated helm chart.

/deploy renku=leafty/gateway-cookie-signing

@leafty leafty temporarily deployed to renku-ci-gw-734 October 9, 2024 08:28 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 9, 2024

You can access the deployment of this PR at https://renku-ci-gw-734.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-gw-734 October 9, 2024 14:54 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-gw-734 October 10, 2024 07:23 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-gw-734 October 10, 2024 07:36 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-gw-734 October 10, 2024 07:51 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-gw-734 October 10, 2024 08:00 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review October 10, 2024 08:57
@leafty leafty requested a review from a team as a code owner October 10, 2024 08:57
@leafty leafty temporarily deployed to renku-ci-gw-734 October 10, 2024 08:57 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-gw-734 October 11, 2024 14:00 — with GitHub Actions Inactive
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really nice. Just had a question regarding rollout

Panaetius
Panaetius previously approved these changes Oct 14, 2024
@leafty leafty deployed to renku-ci-gw-734 October 15, 2024 07:08 — with GitHub Actions Active
@leafty leafty merged commit 14d3ecc into master Oct 15, 2024
13 of 17 checks passed
@leafty leafty deleted the leafty/sign-session-cookie branch October 15, 2024 07:18
@leafty leafty mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants