fix: Fix several missed logging statements #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some places, logging effects were not run because they were not chained correctly. Unfortunately our tests don't use tracked effects for logging and so they didn't catch these cases. The `TestLogger` now suspends logging and thus all these issues of mis-formed logging steps are catched and reported - and then fixed.
jachro
reviewed
Jun 7, 2023
event-log/src/test/scala/io/renku/eventlog/events/producers/cleanup/DispatchRecoverySpec.scala
Outdated
Show resolved
Hide resolved
jachro
reviewed
Jun 7, 2023
...rc/test/scala/io/renku/eventlog/events/producers/triplesgenerated/DispatchRecoverySpec.scala
Outdated
Show resolved
Hide resolved
jachro
reviewed
Jun 7, 2023
...pository/src/test/scala/io/renku/tokenrepository/repository/creation/TokensCreatorSpec.scala
Outdated
Show resolved
Hide resolved
jachro
reviewed
Jun 7, 2023
...pository/src/test/scala/io/renku/tokenrepository/repository/creation/TokensCreatorSpec.scala
Outdated
Show resolved
Hide resolved
jachro
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
TestLoggerlog in the effect and not as a side effect. Same for measuring and logging execution times.Closes: #1534