-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support connected services #1849
Merged
leafty
merged 51 commits into
build/connected-services-final
from
leafty/build-connected-services
May 15, 2024
Merged
feat: support connected services #1849
leafty
merged 51 commits into
build/connected-services-final
from
leafty/build-connected-services
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd9228d
to
648d921
Compare
648d921
to
f15f746
Compare
77fdda5
to
33190c2
Compare
f576bca
to
32bddb0
Compare
987e876
to
87cb311
Compare
76449a1
to
ef61ee4
Compare
24725fc
to
efa3eb1
Compare
Panaetius
requested changes
May 15, 2024
Co-authored-by: Ralf Grubenmann <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
You can access the deployment of this PR at https://renku-ci-nb-1849.dev.renku.ch |
Panaetius
approved these changes
May 15, 2024
fa405ba
into
build/connected-services-final
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to mount repositories from external sources in session. This requires
connected services
support fromrenku-data-services
. Also, the API for starting Renku 2.0 sessions has been modified to accept external repositories.Changes in
notebooks
:UserServer
class to be an abstract class.Renku1UserServer
andRenku2UserServer
inherit fromUserServer
and contain the corresponding adaptations needed to support Renku 1.0 and Renku 2.0 sessions respectively.amalthea
patches to reflect changes ingit-clone
andgit-proxy
.patch_statefulset_tokens()
method invoked when resuming sessions.Changes in
git-clone
:git-clone
container to support cloning repositories from any source.git-clone
container will not crash if a repository cannot be cloned.git provider
must be configured and will be used to clone.renku_access_token
.Changes in
git-proxy
:git-proxy
container to support injecting credentials from external services.git-proxy
is a simple pass-through for anonymous sessions (meaning it should probably not run for anonymous sessions).git provider
will have credentials injected:renku-gateway-auth
for the internal GitLabrenku-data-services
for other servicesrenku_access_token
and therenku_refresh_token
.See: SwissDataScienceCenter/renku-data-services#179This feature can be tested at: https://renku-ci-ds-179.dev.renku.ch/v2.
/deploy renku-data-services=build/add-connected-services-demo renku=build/add-connected-services-demo renku-ui=build/add-connected-services-demo