Skip to content

Commit

Permalink
chore: add icons
Browse files Browse the repository at this point in the history
  • Loading branch information
lorenzo-cavazzi committed Feb 22, 2023
1 parent 1e80e28 commit 68cd9bc
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 8 deletions.
10 changes: 7 additions & 3 deletions client/src/project/Project.present.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ import { ThrottledTooltip } from "../utils/components/Tooltip";
import EntityHeader from "../utils/components/entityHeader/EntityHeader";
import { SshDropdown, SshModal } from "../utils/components/ssh/ssh";
import { useProjectJsonLdQuery } from "../features/projects/ProjectKgApi";

import "./Project.css";
import { StartSessionLink } from "../utils/components/entities/Buttons";
import GitLabConnectButton, { externalUrlToGitLabIdeUrl } from "./components/GitLabConnect";

import "./Project.css";
import rkIconStartWithOptions from "../styles/icons/start-with-options.svg";

function filterPaths(paths, blacklist) {
// Return paths to do not match the blacklist of regexps.
const result = paths.filter(p => blacklist.every(b => p.match(b) === null));
Expand Down Expand Up @@ -502,7 +503,10 @@ function StartSessionButton(props) {
<>
<ButtonWithMenu className="startButton" size="sm" default={defaultAction} color="rk-green" isPrincipal={true}>
<DropdownItem>
<Link className="text-decoration-none" to={launchNotebookUrl}>Start with options</Link>
<Link className="text-decoration-none" to={launchNotebookUrl}>
<img src={rkIconStartWithOptions} className="rk-icon rk-icon-md btn-with-menu-margin" />
Start with options
</Link>
</DropdownItem>
<SshDropdown fullPath={fullPath} gitUrl={gitUrl} />
</ButtonWithMenu>
Expand Down
9 changes: 9 additions & 0 deletions client/src/styles/icons/start-with-options.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 3 additions & 5 deletions client/src/utils/components/ssh/ssh.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,9 @@ function SshDropdown({ fullPath, gitUrl }: SshDropdownProps) {
};

return (
<div>
<DropdownItem onClick={(e: React.MouseEvent<HTMLElement>) => handleClick(e)}>
<img src={rkIconSsh} className="rk-icon rk-icon-md btn-with-menu-margin" /> Start SSH session
</DropdownItem>
</div>
<DropdownItem onClick={(e: React.MouseEvent<HTMLElement>) => handleClick(e)}>
<img src={rkIconSsh} className="rk-icon rk-icon-md btn-with-menu-margin" /> Start SSH session
</DropdownItem>
);
}

Expand Down

0 comments on commit 68cd9bc

Please sign in to comment.