feat: no show empty inputs as defaults

SwissDataScienceCenter · Oct 13, 2022 · dfb4105 · dfb4105
1 parent 53b93de
commit dfb4105
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/client/src/model/RenkuModels.js b/client/src/model/RenkuModels.js
@@ -364,8 +364,6 @@ const projectSchema = new Schema({
   },
 });
 
-const DEFAULT_ENV_VARIABLES = [{ key: "", value: "" }];
-
 const notebooksSchema = new Schema({
   autosaves: {
     schema: {
@@ -393,7 +391,7 @@ const notebooksSchema = new Schema({
       commit: { initial: {} },
       discard: { initial: false },
       options: { initial: {} },
-      environment_variables: { initial: DEFAULT_ENV_VARIABLES },
+      environment_variables: { initial: [] },
       objectStoresConfiguration: { initial: [] },
       includeMergedBranches: { initial: false },
       displayedCommits: { initial: 25 },
@@ -725,5 +723,5 @@ const formGeneratorSchema = new Schema({
 export {
   datasetFormSchema, datasetSchema, datasetImportFormSchema, environmentSchema,
   formGeneratorSchema, issueFormSchema, newProjectSchema, notebooksSchema, notificationsSchema,
-  projectSchema, projectsSchema, statuspageSchema, userSchema, webSocketSchema, DEFAULT_ENV_VARIABLES
+  projectSchema, projectsSchema, statuspageSchema, userSchema, webSocketSchema,
 };
diff --git a/client/src/notebooks/Notebooks.container.js b/client/src/notebooks/Notebooks.container.js
@@ -30,7 +30,6 @@ import { StatusHelper } from "../model/Model";
 import { Url } from "../utils/helpers/url";
 import { sleep } from "../utils/helpers/HelperFunctions";
 import ShowSessionFullscreen from "./components/SessionFullScreen";
-import { DEFAULT_ENV_VARIABLES } from "../model/RenkuModels";
 
 
 /**
@@ -304,7 +303,7 @@ class StartNotebookServer extends Component {
 
     const environmentVariables = this.getEnvironmentVariablesFromSearch(currentSearch);
     this.customEnvVariables = currentSearch && this.autostart && environmentVariables.length ?
-      environmentVariables : DEFAULT_ENV_VARIABLES;
+      environmentVariables : [];
 
     this.state = {
       autosavesCommit: false,