Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect markdown rendering on renku #1496

Closed
safinenko opened this issue Jul 22, 2021 · 2 comments · Fixed by #1501
Closed

Incorrect markdown rendering on renku #1496

safinenko opened this issue Jul 22, 2021 · 2 comments · Fixed by #1501
Labels

Comments

@safinenko
Copy link

Markdown files (*.md) do not seem to be rendered properly when viewed from renkulab.io. You can see it for yourself here: https://renkulab.io/projects/artur.safin/DatalakesHydrodynamics/files/blob/example_run.md

Specifically 2 issues that I found:

  1. For whatever reason, one of the columns in the table seems to have nearly zero width, forcing vertical character stacking, and distorting the table quite a bit as a result.
  2. Syntax highlighting in code snippets is missing.

This is what I see when I'm logged in:

image

For reference, the same file is rendered properly on gitlab: https://renkulab.io/gitlab/artur.safin/DatalakesHydrodynamics/blob/master/example_run.md

This is not a huge issue for me, given that I can always point to the gitlab version, but thought you might want to be aware.

Best,
Artur

@pameladelgado
Copy link
Contributor

hi @safinenko , thanks for making this issue and giving enough details. I will transfer this to renku-ui where our team in charge of the UI can take a look, you can follow from there.

@pameladelgado pameladelgado transferred this issue from SwissDataScienceCenter/renku Sep 10, 2021
@lorenzo-cavazzi
Copy link
Member

Thank you @safinenko for the detailed descriptions! That simplified finding the cause.

Problem 1 should be easy to fix. In short, it seems to be a side effect of a CSS setting we applied a while back.

Problem 2 is already tracked here #1358 . TL;DR; we currently support highlighting code files, but we don't support highlighting code snippets in markdown yet. It's on the list, but it may require some extra work and the priority is currently low (it will come at some point anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants