Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editing datasets without images #1899

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: editing datasets without images #1899

merged 1 commit into from
Jun 13, 2022

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jun 13, 2022

#1887 introduced an error in editing datasets that do not contain images. This PR makes dataset actions work in the following scenarios:

  • Add a dataset without an image
  • Add a dataset with an image
  • Modify a dataset without an image
  • Modify a dataset with an image

/deploy #persist

@ciyer ciyer requested a review from a team as a code owner June 13, 2022 12:04
@ciyer ciyer deployed to renku-ci-ui-1899 June 13, 2022 12:04 Active
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1899.dev.renku.ch

Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fix it.

@ciyer ciyer merged commit b6ee7c5 into master Jun 13, 2022
@ciyer ciyer deleted the 000-dataset-edit branch June 13, 2022 13:25
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants