fix: send dataset current image url when updating the dataset (#1861) #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not changing the dataset image
|
You can access the deployment of this PR at https://renku-ci-ui-1887.dev.renku.ch |
ciyer
requested changes
Jun 9, 2022
There was a problem hiding this comment.
The code changes look good, but when testing I encountered some problems, and maybe we can fix them as part of this issue, since it is so far not too big.
- I get an error when I try to create a dataset that includes an image
(on dev, I can create a dataset and supply an image in the form -- create succeeds, but the image is not is not actually added 🤷 )
- Once I have added an image to the form, there is no way to remove the image
|
@ciyer Thanks for the review and testing, indeed there was something to fix in the creation of the dataset. Fixed in the last commit. |
ciyer
approved these changes
Jun 10, 2022
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to send the url of the current image when updating the dataset so as not to delete the existing image.
Currently the endpoint for updating a dataset requests the url of the current image from the dataset to keep that image, otherwise it deletes the image. This is a workaround for this case, but the API should not delete the image if it is not included in the dataset object when updating a dataset.
closes #1861
/deploy #persist