Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define flows for "Save" button #1957

Closed
1 task
gavin-k-lee opened this issue Jul 14, 2022 · 3 comments
Closed
1 task

Define flows for "Save" button #1957

gavin-k-lee opened this issue Jul 14, 2022 · 3 comments
Milestone

Comments

@gavin-k-lee
Copy link

As part of targetting no/low code solutions and their users, we should implement clickable buttons to run certain commands, like renku save, or git add -all; git commit -m 'message'; git push. Possible breakdown of cases (TBC with devs):
https://www.figma.com/file/x1YHYNJA5PCHYztmAIvvMO/Save-button?node-id=0%3A1

Simplify flows for initial implementation, set scope for future rounds.

Could we lean into a Git GUI for this?

Acceptance criteria

  • confirm all possible cases for this flow
@ciyer ciyer added the 1 label Jul 15, 2022
@ciyer
Copy link
Contributor

ciyer commented Jul 15, 2022

We do not need to wait for the bigger redesign of the sessions flow to implement this, we can already put this into the UI and let users make use of it.

Image

@ciyer
Copy link
Contributor

ciyer commented Aug 6, 2022

SwissDataScienceCenter/renku-notebooks#762 should be merged at the end of the current sprint. That will make the infrastructure necessary for the save button necessary available

@ciyer
Copy link
Contributor

ciyer commented Aug 6, 2022

SwissDataScienceCenter/renku-notebooks#1175 describes the logic needed to support this in the UI.

@ciyer ciyer closed this as completed Aug 6, 2022
Repository owner moved this from Todo to Done in UI Sprints - DEPRECATED Aug 6, 2022
Repository owner moved this from Todo to Done in MIX Feature Team Aug 6, 2022
ciyer pushed a commit that referenced this issue Oct 7, 2022
Fix #1985

BREAKING CHANGE: Requires renku-notebooks 1.12.0 or greater
ciyer pushed a commit that referenced this issue Oct 7, 2022
Fix #1985

BREAKING CHANGE: Requires renku-notebooks 1.12.0 or greater
ciyer pushed a commit that referenced this issue Oct 7, 2022
Fix #1985

BREAKING CHANGE: Requires renku-notebooks 1.12.0 or greater
andre-code pushed a commit that referenced this issue Oct 12, 2022
Fix #1985

BREAKING CHANGE: Requires renku-notebooks 1.12.0 or greater
andre-code pushed a commit that referenced this issue Oct 12, 2022
Fix #1985 #1957 

BREAKING CHANGE: Requires renku-notebooks 1.11.0 or greater
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants