Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timeout for core to release project lock (#1982) #2025

Merged
merged 1 commit into from
Sep 15, 2022
Merged

feat: add timeout for core to release project lock (#1982) #2025

merged 1 commit into from
Sep 15, 2022

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Sep 7, 2022 •
edited
Loading

Fix #1982

/deploy #persist

@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 7, 2022

You can access the deployment of this PR at https://renku-ci-ui-2025.dev.renku.ch

ciyer pushed a commit that referenced this pull request Sep 7, 2022
@cramakri
feat!: add timeout for core to release project lock (#1982) (#2025)
f28c3f8 
BREAKING CHANGE: Requires renku-core v1.7.0 or greater
@ciyer ciyer force-pushed the 1982-locked-dataset branch from 49b7b39 to f28c3f8 Compare September 7, 2022 08:19
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 7, 2022 08:19 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 7, 2022 12:27 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 7, 2022 13:17 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 7, 2022 15:08 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 8, 2022 08:09 Inactive
ciyer pushed a commit that referenced this pull request Sep 12, 2022
@cramakri
feat!: add timeout for core to release project lock (#1982) (#2025)
ecad1f5 
BREAKING CHANGE: Requires renku-core v1.7.0 or greater
@ciyer ciyer force-pushed the 1982-locked-dataset branch from f28c3f8 to ecad1f5 Compare September 12, 2022 12:51
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 12, 2022 12:52 Inactive
ciyer pushed a commit that referenced this pull request Sep 15, 2022
@cramakri
feat!: add timeout for core to release project lock (#1982) (#2025)
12cf89a 
BREAKING CHANGE: Requires renku-core v1.7.0 or greater
@ciyer ciyer force-pushed the 1982-locked-dataset branch from ecad1f5 to 12cf89a Compare September 15, 2022 09:06
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 15, 2022 09:06 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2025 September 15, 2022 11:30 Inactive
@cramakri
feat!: add timeout for core to release project lock (#1982) (#2025)
26b0932 
BREAKING CHANGE: Requires renku-core v1.7.0 or greater
@ciyer ciyer force-pushed the 1982-locked-dataset branch from 12cf89a to 26b0932 Compare September 15, 2022 13:26
@ciyer ciyer marked this pull request as ready for review September 15, 2022 13:26
@ciyer ciyer requested a review from a team as a code owner September 15, 2022 13:26
@ciyer ciyer deployed to renku-ci-ui-2025 September 15, 2022 13:26 Active
@ciyer
Copy link
Contributor Author

ciyer commented Sep 15, 2022

Testing

Visit some projects, click to tabs like Dataset that, before, would often induce a "Project is locked" notification and notice that 1. everything works and 2. there is no notification anymore

andre-code
andre-code approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@ciyer ciyer merged commit 332a052 into master Sep 15, 2022
@ciyer ciyer deleted the 1982-locked-dataset branch September 15, 2022 14:30
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@RenkuBot RenkuBot mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-code andre-code andre-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets currently being modified notifications comes up too frequently
4 participants
@ciyer @RenkuBot @andre-code @cramakri