Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Resource Pools from the UI #2484

Closed
lorenzo-cavazzi opened this issue Apr 19, 2023 · 7 comments · Fixed by #2517
Closed

Support Resource Pools from the UI #2484

lorenzo-cavazzi opened this issue Apr 19, 2023 · 7 comments · Fixed by #2517
Assignees

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Apr 19, 2023

Motivation

We are introducing Resource Access Control in RenkuLab to assign resource pools to specific users.

This requires a few changes in the UI since the session will start within the context of a specific resource pool with an assigned set of resources.

Starting sessions

We will need to query an API to get the list of resources (it should be the GET /resource_pools API here) available to the user.
We will also need to query the project options to get a project's default pool and try to set it.
For quick-started sessions, we will use whatever is the project default or just the global default if nothing local overwrites it; for sessions through the "Start with options" page, we will error if the project-defined pool is not available, and show a warning. User can pick any other available option from the pool on that page.

ℹ️ This means the single resources (CPU, RAM, disk, GPU) won't be selectable as single entities but just as a pre-set. We won't need the notebook_options anymore since there will be just pools with sets of resources.

image

Sessions settings

On the project page, users can set session settings. The abovementioned ones will disappear and be swapped with the new pool sets.
Keep in mind that not everything is disappearing from there. The pinned images won't change, nor the default_url (even tho it will be just a pure string), and probably also the "Automatically fetch LFS data" should not change.

@jdupre81
Copy link

jdupre81 commented Apr 24, 2023

option 1

Basically, and for practical and consistency purposes, the design follows the same design principle of the commit dropdown message.

Image

Image

Image

@jdupre81
Copy link

as a second option I did a design with a short list and put a "Expand Button", but I think the design above looks much better.

Image

Image

Image

@jdupre81
Copy link

Image

Image

@jdupre81
Copy link

Image
Image

@jdupre81
Copy link

Image

@jdupre81
Copy link

Expand.Condense.mov

@lorenzo-cavazzi lorenzo-cavazzi moved this from Design 🎨 to Todo 📌 in UI Sprints - DEPRECATED May 3, 2023
@lorenzo-cavazzi
Copy link
Member Author

We can start working on this. We will broadly follow the design proposal with a modification: to simplify, we can start using a dropdown (similar to the commit selection dropdown) so that we don't need to re-shuffle the content when selecting an item further down on the list. We can define the last visual details before merging.

The data service should be up and running. Please ping Tasko to verify how to include it in a PR (or personal) deployment.

@leafty leafty moved this from Todo 📌 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED May 4, 2023
@leafty leafty self-assigned this May 4, 2023
leafty added a commit that referenced this issue May 12, 2023
leafty added a commit that referenced this issue May 12, 2023
…2506)

Add support for selecting the session class from the new resource pool API.

Notes:
* Update for storage disk size slider will be done in another PR
* Using the real new API endpoints will be done in another PR
* Styling of the drop-down menu will be finalized in another PR

See #2484.
leafty added a commit that referenced this issue May 12, 2023
leafty added a commit that referenced this issue May 16, 2023
…ns (#2519)

Selecting the amount of disk storage is now done separately from the session class.

Notes:
- Using the real new API endpoints will be done in another PR
- Styling of the drop-down menu will be finalized in another PR

See #2484.
leafty added a commit that referenced this issue May 25, 2023
Updates the project session settings page to allow users to set a default session class and a default storage amount.

See #2484.
leafty added a commit that referenced this issue Jun 5, 2023
See #2484.

---------

Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
@lorenzo-cavazzi lorenzo-cavazzi moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Jul 6, 2023
@github-project-automation github-project-automation bot moved this from Review 🔎 to Done ✅ in UI Sprints - DEPRECATED Jul 7, 2023
leafty added a commit that referenced this issue Jul 7, 2023
…e compute resource pools (#2517)

Breaking change: support the the new session classes provided by the compute resource pools.

Sessions started from the UI will now use provisioned resource pools and session classes.

Fixes #2484.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
3 participants