-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Resource Pools from the UI #2484
Comments
Expand.Condense.mov |
We can start working on this. We will broadly follow the design proposal with a modification: to simplify, we can start using a dropdown (similar to the commit selection dropdown) so that we don't need to re-shuffle the content when selecting an item further down on the list. We can define the last visual details before merging. The data service should be up and running. Please ping Tasko to verify how to include it in a PR (or personal) deployment. |
Updates the project session settings page to allow users to set a default session class and a default storage amount. See #2484.
See #2484. --------- Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Motivation
We are introducing Resource Access Control in RenkuLab to assign resource pools to specific users.
This requires a few changes in the UI since the session will start within the context of a specific resource pool with an assigned set of resources.
Starting sessions
We will need to query an API to get the list of resources (it should be the
GET /resource_pools
API here) available to the user.We will also need to query the project options to get a project's default pool and try to set it.
For quick-started sessions, we will use whatever is the project default or just the global default if nothing local overwrites it; for sessions through the "Start with options" page, we will error if the project-defined pool is not available, and show a warning. User can pick any other available option from the pool on that page.
ℹ️ This means the single resources (CPU, RAM, disk, GPU) won't be selectable as single entities but just as a pre-set. We won't need the
notebook_options
anymore since there will be just pools with sets of resources.Sessions settings
On the project page, users can set session settings. The abovementioned ones will disappear and be swapped with the new pool sets.
Keep in mind that not everything is disappearing from there. The pinned images won't change, nor the default_url (even tho it will be just a pure string), and probably also the "Automatically fetch LFS data" should not change.
The text was updated successfully, but these errors were encountered: