Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project visibility button #2515

Closed
bethcg opened this issue May 11, 2023 · 4 comments · Fixed by #2648
Closed

Project visibility button #2515

bethcg opened this issue May 11, 2023 · 4 comments · Fixed by #2648
Assignees

Comments

@bethcg
Copy link

bethcg commented May 11, 2023

Motivation

Some users want to change the visibility (private, public, internal) of their projects. Currently, this can be only done through the Gitlab settings. It is not intuitive how to do it, if you are not an experienced user.
Screenshot 2023-05-11 at 11 07 03
View of Renku Project/Settings page

screenshot_2023-05-11_at_11 06 17_720
View of Gitlab Project/Settings page

Proposal

There are mainly two options:

  • Create a button in the Project page / Settings that allows the user to change the visibility of the project (this may have some corner cases that need to be tackled).
  • Create a button that redirects the user to the Gitlab settings project page within the Renku Project page/ Settings and give indications to the user on how to do the change (and include it in the documentation page).
@bethcg bethcg added the status/triage Issue needs to be triaged label May 11, 2023
@jdupre81 jdupre81 assigned jdupre81 and unassigned jdupre81 May 11, 2023
@jdupre81 jdupre81 assigned jdupre81 and unassigned jdupre81 May 11, 2023
@lorenzo-cavazzi lorenzo-cavazzi removed the status/triage Issue needs to be triaged label May 12, 2023
@jdupre81

This comment was marked as outdated.

@jdupre81

This comment was marked as outdated.

@jdupre81
Copy link

jdupre81 commented Jul 3, 2023

as discussed last week, here is the design for the use case:
Change visibility of my own project + Message on a Confirmation box
Figma prototype

change.visibility.own.project.confirmation.mov

@lorenzo-cavazzi lorenzo-cavazzi moved this from Design 🎨 to Todo 📌 in UI Sprints - DEPRECATED Jul 3, 2023
@lorenzo-cavazzi
Copy link
Member

A few details:

  • For the visibilities, re-use the same text/description we have in the "New project" page (mind they are swapped in the prototype above)
    image
  • Do not allow changing visibilities if the project is forked because it's probably going to fail
  • If the project is part of a group, check the visibility restrictions: E.G. if the group is internal, users can pick only internal and private, but not public.
  • Use the tooltip to explain why users cannot change visibilities in those cases ("Cannot change visibility on forked projects. Please check our documentation" or "This project is inside a private group. Visibility cannon be more permissive then the group one."). No need to show a tooltip when there is nothing relevant to explain.
  • Keep in mind changing visibility might be restricted for other reasons. Errors will happen 😒 . We should keep this in mind for the confirmation modal: when the users confirm the visibility change, we need to wait until it's done and show a green confirmation when all is good, or a red error when something goes wrong with the GitLab message.

@lorenzo-cavazzi lorenzo-cavazzi moved this from Todo 📌 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Jul 14, 2023
@andre-code andre-code moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Jul 19, 2023
@andre-code andre-code moved this from Review 🔎 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Jul 19, 2023
@andre-code andre-code moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Jul 19, 2023
andre-code added a commit that referenced this issue Jul 26, 2023
@github-project-automation github-project-automation bot moved this from Review 🔎 to Done ✅ in UI Sprints - DEPRECATED Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants