Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of Core Service API versions #2764

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Aug 24, 2023

The Core Service supports API versions, and the UI should take advantage of this feature.

Fix #2718
Fix #2755

/deploy #persist extra-values=ui.client.coreApiVersionConfig.coreApiVersion=2.0

@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch 6 times, most recently from 04f5b22 to 36fa6bf Compare August 29, 2023 08:47
@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from 2b34db1 to a00cca1 Compare August 31, 2023 15:27
@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from 63a20c9 to 8a367bb Compare September 1, 2023 13:50
@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from 8a367bb to 9fe89bb Compare September 1, 2023 15:30
@ciyer ciyer temporarily deployed to renku-ci-ui-2764 September 1, 2023 15:52 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 1, 2023

You can access the deployment of this PR at https://renku-ci-ui-2764.dev.renku.ch

@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from 9fe89bb to d7f01d7 Compare September 1, 2023 16:29
@ciyer ciyer temporarily deployed to renku-ci-ui-2764 September 1, 2023 16:29 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from d7f01d7 to 42c7f6f Compare September 4, 2023 07:18
@ciyer ciyer temporarily deployed to renku-ci-ui-2764 September 4, 2023 07:18 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/2718-versioned-api branch from 42c7f6f to 7775c6e Compare September 4, 2023 07:46
@ciyer ciyer temporarily deployed to renku-ci-ui-2764 September 4, 2023 07:47 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2764 September 4, 2023 08:07 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review September 4, 2023 08:35
@ciyer ciyer requested a review from a team as a code owner September 4, 2023 08:35
@leafty leafty self-requested a review September 4, 2023 08:39
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 5, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

leafty added a commit that referenced this pull request Sep 5, 2023
* feat: take advantage of Core Service API versions  (#2718) (#2755) (#2764)

* use API version in projectCoreApi.ts
* use API version in useUpdateDescriptionMutation (#2755)
* use API version in datasetsCore.api.ts
* use API version in WorkflowsApi.ts
* use API version in old client-based code
* update tests to match new URLs
* set up build to configure core service version

* cleanup

---------

Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use versioned url for renku-core Use versioned API when interacting with renku-core
4 participants