-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take advantage of Core Service API versions #2764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04f5b22
to
36fa6bf
Compare
2b34db1
to
a00cca1
Compare
63a20c9
to
8a367bb
Compare
8a367bb
to
9fe89bb
Compare
You can access the deployment of this PR at https://renku-ci-ui-2764.dev.renku.ch |
9fe89bb
to
d7f01d7
Compare
d7f01d7
to
42c7f6f
Compare
42c7f6f
to
7775c6e
Compare
leafty
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tearing down the temporary RenkuLab deplyoment for this PR. |
leafty
added a commit
that referenced
this pull request
Sep 5, 2023
* feat: take advantage of Core Service API versions (#2718) (#2755) (#2764) * use API version in projectCoreApi.ts * use API version in useUpdateDescriptionMutation (#2755) * use API version in datasetsCore.api.ts * use API version in WorkflowsApi.ts * use API version in old client-based code * update tests to match new URLs * set up build to configure core service version * cleanup --------- Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
This was referenced Sep 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Core Service supports API versions, and the UI should take advantage of this feature.
Fix #2718
Fix #2755
/deploy #persist extra-values=ui.client.coreApiVersionConfig.coreApiVersion=2.0