feat: update DatasetAddToProject to use versioned core-service endpoints #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2788.dev.renku.ch |
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
c35d182 to
e777af7
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
e777af7 to
93a21fc
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
93a21fc to
04267c0
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
04267c0 to
35e8568
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
35e8568 to
3a4757e
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
|
For testing you need a dataset with files, like test-new-dataset
|
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
3a4757e to
2ec90ac
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
lorenzo-cavazzi
previously approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Great fix! I could use (almost) all the dataset functionalities again. I'm wondering if we should extend the e2e tests to catch these cases -- can be a follow-up PR.
Also, I noticed there are failures when uploading files on older datasets cause the cache.files_upload endpoint isn't versioned (see screenshot). Not sure if it's worth fixing it in this PR or create a bug issue to take separately
Comment on lines
64
to
107
| // TODO: restore after #1585 | ||
| // eslint-disable-next-line | ||
| function addForkNotification( | ||
| notifications, | ||
| url, | ||
| info, | ||
| startingLocation, | ||
| success = true, | ||
| excludeStarting = false, | ||
| visibilityException = false | ||
| ) { | ||
| if (success && !visibilityException) { | ||
| const locations = excludeStarting ? [url] : [url, startingLocation]; | ||
| notifications.addSuccess( | ||
| notifications.Topics.PROJECT_FORKED, | ||
| `Project ${info.name} successfully created.`, | ||
| url, | ||
| "Show project", | ||
| locations, | ||
| `The project has been successfully forked to ${info.namespace}/${info.path}` | ||
| ); | ||
| } else if (visibilityException) { | ||
| const locations = excludeStarting ? [url] : [url, startingLocation]; | ||
| notifications.addWarning( | ||
| notifications.Topics.PROJECT_FORKED, | ||
| `Project ${info.name} has been created with an exception.`, | ||
| url, | ||
| "Show project", | ||
| locations, | ||
| `The project has been successfully forked to ${info.namespace}/${info.path} | ||
| although it was not possible to configure the visibility${visibilityException?.message}` | ||
| ); | ||
| } else { | ||
| const locations = excludeStarting ? [] : [startingLocation]; | ||
| notifications.addError( | ||
| notifications.Topics.PROJECT_FORKED, | ||
| "Forking operation did not complete.", | ||
| startingLocation, | ||
| "Try again", | ||
| locations, | ||
| "The fork operation did not run to completion. It is possible the project has been created, but some" + | ||
| "elements may have not been cloned properly." | ||
| ); | ||
| } | ||
| } | ||
| // function addForkNotification( | ||
| // notifications, | ||
| // url, | ||
| // info, | ||
| // startingLocation, | ||
| // success = true, | ||
| // excludeStarting = false, | ||
| // visibilityException = false | ||
| // ) { | ||
| // if (success && !visibilityException) { | ||
| // const locations = excludeStarting ? [url] : [url, startingLocation]; | ||
| // notifications.addSuccess( | ||
| // notifications.Topics.PROJECT_FORKED, | ||
| // `Project ${info.name} successfully created.`, | ||
| // url, | ||
| // "Show project", | ||
| // locations, | ||
| // `The project has been successfully forked to ${info.namespace}/${info.path}` | ||
| // ); | ||
| // } else if (visibilityException) { | ||
| // const locations = excludeStarting ? [url] : [url, startingLocation]; | ||
| // notifications.addWarning( | ||
| // notifications.Topics.PROJECT_FORKED, | ||
| // `Project ${info.name} has been created with an exception.`, | ||
| // url, | ||
| // "Show project", | ||
| // locations, | ||
| // `The project has been successfully forked to ${info.namespace}/${info.path} | ||
| // although it was not possible to configure the visibility${visibilityException?.message}` | ||
| // ); | ||
| // } else { | ||
| // const locations = excludeStarting ? [] : [startingLocation]; | ||
| // notifications.addError( | ||
| // notifications.Topics.PROJECT_FORKED, | ||
| // "Forking operation did not complete.", | ||
| // startingLocation, | ||
| // "Try again", | ||
| // locations, | ||
| // "The fork operation did not run to completion. It is possible the project has been created, but some" + | ||
| // "elements may have not been cloned properly." | ||
| // ); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Should we remove this, or create a follow-up pr and link to that one? I fear the comment "restore after #1585" is rather outdated 😁
There was a problem hiding this comment.
😆 I kept it in there because it was there before and did not understand the context. Let us just remove it.
ciyer
force-pushed
the
ciyer/000-add-dataset-version
branch
from
2ec90ac to
2874ff1
Compare
ciyer
temporarily deployed
to
renku-ci-ui-2788
GitHub Actions
Inactive
lorenzo-cavazzi
approved these changes
Sep 14, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have DatasetAddToProject use versioned core-service endpoints.
Follow-up to #2764
/deploy #persist