Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles for form elements (#1964) #1979

Merged
merged 3 commits into from
Aug 2, 2022
Merged

feat: add styles for form elements (#1964) #1979

merged 3 commits into from
Aug 2, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jul 29, 2022

This PR apply new design system for form elements (input, input-groups, checkbox, radio, select*, button-groups).
Note: To customize the display of the selection options it is necessary to create a custom component, it will not be included here.

Design System: https://zeroheight.com/7c23c970c/p/90b4ba-renku---design-system

form styles

Rel #1964
/deploy #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-1979 July 29, 2022 11:38 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1979.dev.renku.ch

@andre-code andre-code marked this pull request as ready for review July 29, 2022 16:01
@andre-code andre-code requested a review from a team as a code owner July 29, 2022 16:01
@andre-code andre-code temporarily deployed to renku-ci-ui-1979 July 29, 2022 16:02 Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! 🎉 I made some small scss refactorings to remove duplication, and I think this can be merged.

@ciyer ciyer deployed to renku-ci-ui-1979 August 2, 2022 11:47 Active
@ciyer ciyer merged commit 9c2495d into master Aug 2, 2022
@ciyer ciyer deleted the 1964-form-styles branch August 2, 2022 13:05
@RenkuBot
Copy link
Contributor

RenkuBot commented Aug 2, 2022

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 2.7.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants