Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update message when custom commit or branch not found (#1777) #2141

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Nov 14, 2022

PR to update message when custom commit or branch not found.

error commit branch both

Closes #1777

/deploy renku=000-new-notebook-renderer-tests #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 14, 2022 16:18 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2141.dev.renku.ch

@andre-code andre-code force-pushed the 1777-not-found-branch-in-sessions branch from 4391905 to 15b6269 Compare November 15, 2022 12:35
@andre-code andre-code changed the title WIP feat: update message when custom commit or branch not found (#1777) feat: update message when custom commit or branch not found (#1777) Nov 15, 2022
@andre-code andre-code marked this pull request as ready for review November 15, 2022 12:35
@andre-code andre-code requested a review from a team as a code owner November 15, 2022 12:35
@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 15, 2022 12:35 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 15, 2022 14:11 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 15, 2022 14:28 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 15, 2022 15:07 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2141 November 15, 2022 15:43 Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well and the code looks good 🚀

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 17, 2022 14:06 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 17, 2022 16:06 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 17, 2022 16:19 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 18, 2022 14:40 Inactive
@lorenzo-cavazzi lorenzo-cavazzi force-pushed the 1777-not-found-branch-in-sessions branch from 634fc64 to 1b46e13 Compare November 18, 2022 15:13
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 18, 2022 15:13 Inactive
@lorenzo-cavazzi lorenzo-cavazzi force-pushed the 1777-not-found-branch-in-sessions branch from 1b46e13 to acc6bad Compare November 18, 2022 16:56
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2141 November 18, 2022 16:56 Inactive
@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2141 November 18, 2022 18:43 Active
@lorenzo-cavazzi lorenzo-cavazzi merged commit e90ad71 into master Nov 18, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 1777-not-found-branch-in-sessions branch November 18, 2022 22:44
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants