Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): prevent resetting user inputs on the Fork component #2144

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Nov 16, 2022

WIP

/deploy #persist

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 16, 2022 14:24 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2144.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 16, 2022 17:31 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 16, 2022 17:52 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 16, 2022 22:19 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 06:56 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 07:38 Inactive
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review November 17, 2022 07:50
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner November 17, 2022 07:50
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 10:46 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 10:51 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 12:19 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 12:53 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 14:47 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 15:06 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 17, 2022 19:28 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2144 November 18, 2022 10:52 Inactive
andre-code
andre-code previously approved these changes Nov 18, 2022
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, as a quick fix it works very well.

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! With this fix in place, we should be able to start working through the backlog, and we can return to this some time later.

@lorenzo-cavazzi lorenzo-cavazzi merged commit 4ffb481 into master Nov 18, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 000-fix-forks branch November 18, 2022 13:02
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants