Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Fork components #2157

Closed
lorenzo-cavazzi opened this issue Nov 18, 2022 · 0 comments · Fixed by #2176
Closed

Fix the Fork components #2157

lorenzo-cavazzi opened this issue Nov 18, 2022 · 0 comments · Fixed by #2176
Assignees

Comments

@lorenzo-cavazzi
Copy link
Member

Motivation

We recently made a quickfix to prevent the Modal component from resetting every time the Redux store updates (connect was triggering mapStateToProps for any change to state -- see here for the changes #2144 ).
Now projects and namespaces are not connected properly to the final component.

Proposal

We should fix the <ForkProjectMapper> component and its descendants.
Ideally, we can move away from the ProjectsCoordinator and leverage RTK's createApi to fetch featured projects and available namespaces. In the process, we will probably remove also ForkProjectMapper leaving just ForkProject where we import the new use(xyz)Query functions created through createApi.

Follow-up ⚠️

After closing this issue, we should create ore or more follow-up issues to swap the other ProjectsCoordinator functions with the new RTK Query functions.

@andre-code andre-code self-assigned this Nov 28, 2022
@andre-code andre-code moved this from Todo to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Nov 28, 2022
@andre-code andre-code moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Nov 30, 2022
@andre-code andre-code moved this from Review 🔎 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Nov 30, 2022
@andre-code andre-code moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Dec 1, 2022
andre-code added a commit that referenced this issue Dec 5, 2022
* feat: refactor Fork a project to use redux toolkit to get namespaces, visibilities and user projects

Fix #2157
Repository owner moved this from Review 🔎 to Done ✅ in UI Sprints - DEPRECATED Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants