You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently made a quickfix to prevent the Modal component from resetting every time the Redux store updates (connect was triggering mapStateToProps for any change to state -- see here for the changes #2144 ).
Now projects and namespaces are not connected properly to the final component.
Proposal
We should fix the <ForkProjectMapper> component and its descendants.
Ideally, we can move away from the ProjectsCoordinator and leverage RTK's createApi to fetch featured projects and available namespaces. In the process, we will probably remove also ForkProjectMapper leaving just ForkProject where we import the new use(xyz)Query functions created through createApi.
Follow-up ⚠️
After closing this issue, we should create ore or more follow-up issues to swap the other ProjectsCoordinator functions with the new RTK Query functions.
The text was updated successfully, but these errors were encountered:
Motivation
We recently made a quickfix to prevent the Modal component from resetting every time the Redux store updates (
connect
was triggeringmapStateToProps
for any change tostate
-- see here for the changes #2144 ).Now projects and namespaces are not connected properly to the final component.
Proposal
We should fix the
<ForkProjectMapper>
component and its descendants.Ideally, we can move away from the
ProjectsCoordinator
and leverage RTK'screateApi
to fetch featured projects and available namespaces. In the process, we will probably remove alsoForkProjectMapper
leaving justForkProject
where we import the newuse(xyz)Query
functions created throughcreateApi
.Follow-up⚠️
After closing this issue, we should create ore or more follow-up issues to swap the other
ProjectsCoordinator
functions with the new RTK Query functions.The text was updated successfully, but these errors were encountered: