Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info on websockets #2189

Merged
merged 5 commits into from
Dec 8, 2022
Merged

docs: add info on websockets #2189

merged 5 commits into from
Dec 8, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

After trying a few solutions on the UI side (#2172) and involving other team members, we find out the issue that was preventing WebSockets from staying alive for more than a few minutes.

This doesn't require any change on the UI, so the PR is just a refresh on the WebSockets documentation, with an indication of the issue we faced so we won't forget about it.

fix #2167

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner December 6, 2022 10:30
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to get this documented, since the WebSockets are a little special to handle. I have two small suggestions -- overall it looks very good.

the loop stops.
server sends the same notification to each of them. When the last user's channel is
removed, the loop stops.
We should implement a strategy to redirect all the user requests from the same user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to add a link to #2184 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Added

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorenzo-cavazzi lorenzo-cavazzi merged commit bdef119 into master Dec 8, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 2167-websockets branch December 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket connection closed with 1006 error
2 participants