-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info on websockets #2189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to get this documented, since the WebSockets are a little special to handle. I have two small suggestions -- overall it looks very good.
the loop stops. | ||
server sends the same notification to each of them. When the last user's channel is | ||
removed, the loop stops. | ||
We should implement a strategy to redirect all the user requests from the same user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to add a link to #2184 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes! Added
Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After trying a few solutions on the UI side (#2172) and involving other team members, we find out the issue that was preventing WebSockets from staying alive for more than a few minutes.
This doesn't require any change on the UI, so the PR is just a refresh on the WebSockets documentation, with an indication of the issue we faced so we won't forget about it.
fix #2167