Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): update S3 sources descriptions #2207

Merged
merged 2 commits into from
Dec 12, 2022
Merged

chore(client): update S3 sources descriptions #2207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48082e6
chore(client): update s3 sources descriptions
lorenzo-cavazzi Dec 9, 2022
a76d794
style: extract common code and reword description
cramakri Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions client/src/notebooks/ObjectStoresConfig.present.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { faTrash } from "@fortawesome/free-solid-svg-icons";
import { Map, List } from "immutable";

import { ExternalLink } from "../utils/components/ExternalLinks";

function S3ExplanationLink({ title }) {
const theTitle = title ?? "S3-compatible storage";
return <ExternalLink role="text" title={theTitle}
url="https://en.wikipedia.org/wiki/Amazon_S3#S3_API_and_competing_services" />;
}


function ObjectStoreSummary({ objectStoreConfiguration }) {
return <Fragment>
Expand All @@ -41,7 +49,8 @@ function ObjectStoresConfigurationButton({ objectStoresConfiguration, toggleShow
Cloud Storage
</Label> &nbsp; &nbsp;
<FormText color="muted">
Use data from sources like AWS S3, Google Cloud Storage, or Azure Blob Storage.
Use data from <S3ExplanationLink title="S3-compatible storage" /> sources like AWS S3,
Google Cloud Storage, etc.
</FormText> {" "}
<br />
{
Expand Down Expand Up @@ -305,8 +314,8 @@ function ObjectStoresConfigurationModal({ objectStoresConfiguration, showObjectS
<ModalHeader toggle={onClose}>Object Store Configuration</ModalHeader>
<ModalBody>
<p>
Provide credentials to use cloud storage like {" "}
AWS S3, Google Cloud Storage, or Azure Blob Storage.
Provide credentials to use <S3ExplanationLink title="S3-compatible storage" /> like{" "}
AWS S3, Google Cloud Storage, etc.
</p>
<ObjectStoresTable
objectStoresConfiguration={storesConfig}
Expand Down