Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles button with menu and group button (#2200) #2243

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Dec 20, 2022

PR to add button with menu and round group button styles.

Screenshot 2022-12-20 at 14 47 14

split-button

Closes #2200

/deploy #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2243 December 20, 2022 07:28 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2243.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-2243 December 20, 2022 11:16 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2243 December 20, 2022 13:01 — with GitHub Actions Inactive
@andre-code andre-code changed the title WIP feat: add styles btn group feat: add styles button with menu and group button (#2200) Dec 20, 2022
@andre-code andre-code marked this pull request as ready for review December 20, 2022 13:47
@andre-code andre-code requested a review from a team as a code owner December 20, 2022 13:47
@andre-code andre-code temporarily deployed to renku-ci-ui-2243 December 20, 2022 14:09 — with GitHub Actions Inactive
@andre-code andre-code deployed to renku-ci-ui-2243 December 20, 2022 15:30 — with GitHub Actions Active
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons look much better now 🎉
image

And the code is also good! ✅

@andre-code andre-code merged commit 41e027f into master Dec 22, 2022
@andre-code andre-code deleted the 2200-split-buttton branch December 22, 2022 08:23
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use unified split button
3 participants