fix(client)!: update KG status indexing percentage #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2255.dev.renku.ch |
|
P.S: click on the gif to see the full version -- GitHub shows only the initial N seconds as a preview |
|
@lorenzo-cavazzi we've just merged the PR so you can do on this PR now. |
lorenzo-cavazzi
had a problem deploying
to
renku-ci-ui-2255
GitHub Actions
Failure
lorenzo-cavazzi
had a problem deploying
to
renku-ci-ui-2255
GitHub Actions
Failure
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
ciyer
reviewed
Jan 3, 2023
lorenzo-cavazzi
force-pushed
the
graph1253-status-api
branch
from
51529e7 to
d33e60c
Compare
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
|
Hi guys. We've just noticed that our acceptance-tests are not compatible with the version of KG we have on our |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
|
FYI, we've just merged a fix to make acceptance-tests work with both pre- and post- status endpoint changes. |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
BREAKING CHANGE: require a new version of renku-graph re SwissDataScienceCenter/renku-graph#1253
lorenzo-cavazzi
force-pushed
the
graph1253-status-api
branch
from
06c1faa to
9985fc1
Compare
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2255
GitHub Actions
Inactive
* restore project-lock tests * fix KG status endpoint fixtures * add KG status progress tests
lorenzo-cavazzi
had a problem deploying
to
renku-ci-ui-2255
GitHub Actions
Failure
ciyer
approved these changes
Jan 6, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the UI to the new response from the KG status endpoint, and restores the percentage indication when indexing a project.
As a comparison, on the following video the current PR deployment is on the left and "dev" on the right.
BREAKING CHANGE: requires a yet-unreleased version of renku-graph
re SwissDataScienceCenter/renku-graph#1253
/deploy renku-graph=development #persist #cypress