Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply correct visibility limitations on fork #2299

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 16, 2023

Fix #2296

/deploy #persist #cypress renku=auto-update/renku-ui-3.0.0

ciyer pushed a commit that referenced this pull request Jan 16, 2023
@ciyer ciyer force-pushed the 2296-fork-visibility branch from ab70f8a to f8e3724 Compare January 16, 2023 13:36
ciyer pushed a commit that referenced this pull request Jan 16, 2023
@ciyer ciyer force-pushed the 2296-fork-visibility branch from f8e3724 to 41f9fe1 Compare January 16, 2023 13:38
ciyer pushed a commit that referenced this pull request Jan 16, 2023
@ciyer ciyer force-pushed the 2296-fork-visibility branch from 41f9fe1 to 318f2b6 Compare January 16, 2023 14:06
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2299.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-2299 January 17, 2023 08:23 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review January 17, 2023 08:59
@ciyer ciyer requested a review from a team as a code owner January 17, 2023 08:59
@ciyer
Copy link
Contributor Author

ciyer commented Jan 17, 2023

Testing

Navigate to a project and fork it. Try out a few combinations of project visibility / namespace visibility (e.g., public project / private namespace, private project / internal namespace): the visibility options for the forked project should be limited to those allowed by more restrictive of project and namespace.

Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected 🚀

@ciyer ciyer temporarily deployed to renku-ci-ui-2299 January 17, 2023 09:58 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2299 January 17, 2023 10:21 — with GitHub Actions Active
@ciyer ciyer merged commit 6bfa02c into master Jan 17, 2023
@ciyer ciyer deleted the 2296-fork-visibility branch January 17, 2023 11:29
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forking a project with restricted visibility lets me choose public visibility
5 participants