-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dropdown for session options when many choices #2461
Conversation
The button group used for session options is replaced with a dropdown menu when there are more than 5 choices. This is done to avoid choices spilling over other options. Fixes #2237.
f8058a6
to
74d4601
Compare
You can access the deployment of this PR at https://renku-ci-ui-2461.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution using CSS modules!
Apart from a couple of linting errors to fix, it would be nice to use the same thicker border already in use for the selected radio button. Otherwise, it feels "unselected".
I noticed the size is also slightly different; perhaps it's related to the borders? Please double-check it again after adjusting borders just to be on the safe side 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent solution, it works well!
Tearing down the temporary RenkuLab deplyoment for this PR. |
The button group used for session options is replaced with a dropdown
menu when there are more than 5 choices. This is done to avoid choices
spilling over other options.
Fixes #2237.
/deploy #persist #cypress