fix(client): prevent dropping pinned images #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2466
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2466.dev.renku.ch |
leafty
approved these changes
Apr 13, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty bug accidentally introduced here #2410 that prevents pinned images from being picked up correctly.
In the screenshot, I tested a project with a pinned image that was picked up correctly -- it's from a different commit than the current one.
You can use this project to test it https://dev.renku.ch/projects/lorenzo.cavazzi.tech/1408-pinned-image
/deploy #persist #cypress renku=renku-ui-3.4.2-updates
fix #2458