Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): handle 404 return code when accessing a project by id #2476

Merged
merged 10 commits into from
Apr 19, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Apr 17, 2023

Fixes #1188.

The not found page has also been updated when handling this case:
localhost_3000_projects_12345

/deploy #persist #cypress

@leafty leafty marked this pull request as ready for review April 18, 2023 12:27
@leafty leafty requested a review from a team as a code owner April 18, 2023 12:27
@leafty leafty temporarily deployed to renku-ci-ui-2476 April 18, 2023 14:04 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2476.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-2476 April 18, 2023 17:25 — with GitHub Actions Inactive
@leafty leafty deployed to renku-ci-ui-2476 April 19, 2023 06:47 — with GitHub Actions Active
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, and the code and tests are just fine! Let's merge this 🚀

No more infinite bouncing dots for anonymous users

image

@leafty leafty merged commit 61b3e1e into master Apr 19, 2023
@leafty leafty deleted the leafty/1188-fix-stuck-anon-project-id branch April 19, 2023 08:08
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck in loading state when accessing project by numeric id as anonymous user
3 participants