fix(client): provide the correct notebook search param for anon users #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "Start a session" button for anonymous users viewing a notebook in a project's files tab. Fixes #2477.
|
You can access the deployment of this PR at https://renku-ci-ui-2479.dev.renku.ch |
leafty
commented
Apr 18, 2023
tests/cypress/e2e/project.spec.ts
Outdated
| cy.contains("01-CountFlights.ipynb").should("be.visible"); | ||
| cy.contains("01-CountFlights.ipynb").click(); | ||
| cy.wait("@getCountFlights"); | ||
| cy.get("#checkNotebookIcon", { timeout: 10_000 }) |
There was a problem hiding this comment.
Note: I think the UI is waiting for a kg request in this case; not sure how to avoid waiting for the button to go from "loading" to "Start a session" faster.
|
The code looks good. Do you mind if I review this after merging #2469? I found a tricky case while testing but I assume it's already handled there |
…rt-session-button
lorenzo-cavazzi
approved these changes
Apr 20, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Start a session" button for anonymous users viewing a notebook in a project's files tab.
Fixes #2477.
/deploy #persist #cypress