Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): prevent content layout shift when selecting a template #2482

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Apr 18, 2023

Issue: when hovering templates in the new project form, the content gets shifted due to the added border.
See: https://dev.renku.ch/projects/new.

The new template cards do not shift around when hovered or selected.
See: https://leafty.dev.renku.ch/projects/new.

/deploy #persist #cypress

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2482.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-2482 April 18, 2023 14:08 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2482 April 20, 2023 13:31 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review April 20, 2023 14:03
@leafty leafty requested a review from a team as a code owner April 20, 2023 14:03
@leafty leafty temporarily deployed to renku-ci-ui-2482 April 20, 2023 14:05 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2482 April 20, 2023 15:33 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2482 April 21, 2023 05:02 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leafty leafty deployed to renku-ci-ui-2482 April 21, 2023 06:54 — with GitHub Actions Active
@leafty leafty merged commit c59770c into master Apr 21, 2023
@leafty leafty deleted the leafty/prevent-content-layout-shift-template-selection branch April 21, 2023 08:49
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants